KNOX-3100 - RemoteAuthProvider to accept multiple group headers #997
+96
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Initial iteration of the RemoteAuthProvider has support for a single HTTP Header containing the group memberships. The Pre API in the Knox Auth Service breaks memberships up across multiple headers to manage the size.
We need to determine a syntax as an explicit list or a range with some builtin syntax of a numeric suffix. Otherwise, it will need a list of possible header names with it accommodating the largest set which seems odd.
How was this patch tested?
Ran existing unit tests plus new tests for the new functionality.