Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18192: generator module should run under java 11 #18114

Merged
merged 1 commit into from
Dec 10, 2024
Merged

KAFKA-18192: generator module should run under java 11 #18114

merged 1 commit into from
Dec 10, 2024

Conversation

frankvicky
Copy link
Contributor

JIRA: KAFKA-18192

Both Streams and Clients are now using Java 11, but the Generator modules are not. This discrepancy causes an issue where developers cannot use JDK 11 to run tests for both modules.

Please refer to the discussion of #17522 for further details

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Dec 10, 2024
@chia7712
Copy link
Contributor

@frankvicky could you please use JDK 11 to build/test/check both streams and clients modules?

@frankvicky
Copy link
Contributor Author

command: ./gradlew :clients:check -PmaxTestRetries=1 -PmaxTestRetryFailures=3

Screenshot 2024-12-10 at 12 24 45 PM 1

@frankvicky
Copy link
Contributor Author

Command: ./gradlew :streams:check -PmaxTestRetries=1 -PmaxTestRetryFailures=3
image

@chia7712 chia7712 merged commit 408d0f6 into apache:trunk Dec 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
build Gradle build or GitHub Actions ci-approved small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankvicky @chia7712