Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16339: [4/4 KStream#flatTransformValues] Remove Deprecated "transformer" methods and classes #17882

Open
wants to merge 14 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-16339: [4/4 KStream#flatTransformValues] Remove Deprecated "transformer" methods and classes #17882

wants to merge 14 commits into from

Conversation

fonsdant
Copy link
Contributor

No description provided.

@fonsdant
refactor(streams)!: remove flatTransformValues from KStream
d9c6abb 
Signed-off-by: Joao Pedro Fonseca Dantas <[email protected]>
@fonsdant
refactor(streams)!: remove flatTransformValues from KStreamImpl
da0e488 
Signed-off-by: Joao Pedro Fonseca Dantas <[email protected]>
@fonsdant
test(streams): remove flatTransformValues from StreamsBuilderTest
06d291b 
Signed-off-by: Joao Pedro Fonseca Dantas <[email protected]>
@fonsdant
test(streams): remove flatTransformValues from KStreamImplTest
011e0e2 
Signed-off-by: Joao Pedro Fonseca Dantas <[email protected]>
@fonsdant
refactor(streams-scala)!: remove flatTransformValues from KStream
c7dddda 
Signed-off-by: Joao Pedro Fonseca Dantas <[email protected]>
@fonsdant
docs(streams)!: replace flatTransformValues with processValues in KSt…
aabbb2c 
…ream

Signed-off-by: Joao Pedro Fonseca Dantas <[email protected]>
@fonsdant
docs(streams)!: replace flatTransformValues with processValues in Con…
320c2c1 
…nectedStoreProvider

Signed-off-by: Joao Pedro Fonseca Dantas <[email protected]>
@fonsdant
test(streams): add shouldUseSpecifiedNameForProcessValuesOperation
3b42776 
Signed-off-by: Joao Pedro Fonseca Dantas <[email protected]>
@fonsdant fonsdant force-pushed the kstream-flat-transform-values-remove-deprecated-transformer-methods-and-classes branch from 8088b56 to 3b42776 Compare November 26, 2024 00:29
@fonsdant fonsdant marked this pull request as ready for review November 26, 2024 01:46
@fonsdant
Copy link
Contributor Author

Hi, @mjsax! I have a question for this PR. I'm wondering if shouldNotAllowNullStoreNameOnProcessValues were not duplicated as shouldNotAllowNullStoreNamesOnProcessValues (note the little "s" in "Names"). What do you think?

@mjsax
Copy link
Member

mjsax commented Nov 27, 2024

Looking into the test code, it seem the s just goes somewhere else? There is shouldNotAllowNullStoreNameOnProcess and shouldNotAllowNullStoreName[s]OnProcess, one taking (String) null and the other taking a (String[]) null, so it seems we are fine?

@fonsdant fonsdant force-pushed the kstream-flat-transform-values-remove-deprecated-transformer-methods-and-classes branch from 5b8bbc8 to 0b18c5a Compare November 27, 2024 10:06
@fonsdant
Copy link
Contributor Author

Looking into the test code, it seem the s just goes somewhere else? There is shouldNotAllowNullStoreNameOnProcess and shouldNotAllowNullStoreName[s]OnProcess, one taking (String) null and the other taking a (String[]) null, so it seems we are fine?

Thanks, @mjsax! Alright, just a confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-approved streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fonsdant @mjsax