Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1705] improvement(server): Bump Jetty from 9.3.24.v20180605 to 9.4.54.v20240208 #1786

Closed
wants to merge 1 commit into from

Conversation

rickyma
Copy link
Contributor

@rickyma rickyma commented Jun 13, 2024

What changes were proposed in this pull request?

Bump Jetty from 9.3.24.v20180605 to 9.4.54.v20240208.

Why are the changes needed?

For: #1705.
Since Uniffle still needs to support JDK 8, and Jetty no longer supports JDK 8 from version 10.x onwards, we are temporarily unable to upgrade Jetty to 10.x or higher versions. Therefore, we will first upgrade Jetty to the latest version of 9.x (which is 9.4.54.v20240208), although it is no longer maintained, it is still a stable version and includes numerous bug fixes.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

Copy link

Test Results

1 245 files   - 1 189  1 245 suites   - 1 189   3h 10m 3s ⏱️ - 1h 50m 51s
  504 tests  -   433    467 ✅  -   469   1 💤 ±0   1 ❌ + 1  35 🔥 +35 
6 198 runs   - 4 659  6 110 ✅  - 4 733  12 💤  - 2  14 ❌ +14  62 🔥 +62 

For more details on these failures and errors, see this check.

Results for commit 6341d81. ± Comparison against base commit 3d0c91a.

This pull request removes 460 and adds 27 tests. Note that renamed tests count towards both.
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testCombineBuffer
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testCommitBlocksWhenMemoryShuffleDisabled
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testOnePartition
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteException
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteNormal
org.apache.hadoop.mapred.SortWriteBufferTest ‑ testReadWrite
org.apache.hadoop.mapred.SortWriteBufferTest ‑ testSortBufferIterator
org.apache.hadoop.mapreduce.RssMRUtilsTest ‑ applyDynamicClientConfTest
org.apache.hadoop.mapreduce.RssMRUtilsTest ‑ baskAttemptIdTest
org.apache.hadoop.mapreduce.RssMRUtilsTest ‑ blockConvertTest
…
org.apache.uniffle.common.filesystem.HadoopFilesystemProviderTest ‑ org.apache.uniffle.common.filesystem.HadoopFilesystemProviderTest
org.apache.uniffle.common.security.HadoopSecurityContextTest ‑ org.apache.uniffle.common.security.HadoopSecurityContextTest
org.apache.uniffle.common.security.SecurityContextFactoryTest ‑ org.apache.uniffle.common.security.SecurityContextFactoryTest
org.apache.uniffle.test.AccessCandidatesCheckerHadoopTest ‑ org.apache.uniffle.test.AccessCandidatesCheckerHadoopTest
org.apache.uniffle.test.AccessCandidatesCheckerKerberizedHadoopTest ‑ org.apache.uniffle.test.AccessCandidatesCheckerKerberizedHadoopTest
org.apache.uniffle.test.AccessClusterTest ‑ org.apache.uniffle.test.AccessClusterTest
org.apache.uniffle.test.AssignmentWithTagsTest ‑ org.apache.uniffle.test.AssignmentWithTagsTest
org.apache.uniffle.test.CoordinatorAdminServiceTest ‑ org.apache.uniffle.test.CoordinatorAdminServiceTest
org.apache.uniffle.test.CoordinatorAssignmentTest ‑ org.apache.uniffle.test.CoordinatorAssignmentTest
org.apache.uniffle.test.CoordinatorGrpcTest ‑ org.apache.uniffle.test.CoordinatorGrpcTest
…

@rickyma rickyma marked this pull request as draft June 13, 2024 18:46
@rickyma
Copy link
Contributor Author

rickyma commented Jun 14, 2024

Closed temporarily because of tests failures. It's not easy to upgrade Jetty.

@rickyma rickyma closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant