[fix] SQL query source #9173
Merged
[fix] SQL query source #9173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--fix-sqla-source
branch
from
6555b62 to
014506d
Compare
john-bodley
commented
Feb 20, 2020
| @@ -314,6 +314,12 @@ def get_sqla_engine( | |||
| params.update(self.get_encrypted_extra()) | |||
|
|
|||
| if DB_CONNECTION_MUTATOR: | |||
| if not source and request and request.referrer: | |||
There was a problem hiding this comment.
This is similar logic to what was defined in get_df however it's been pushed further up the stack. Note we only try to mutate the source if it isn't explicitly defined.
Codecov Report
@@ Coverage Diff @@
## master #9173 +/- ##
==========================================
- Coverage 59.16% 59.13% -0.04%
==========================================
Files 372 372
Lines 11935 11938 +3
Branches 2927 2925 -2
==========================================
- Hits 7061 7059 -2
- Misses 4694 4699 +5
Partials 180 180
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley--fix-sqla-source
branch
from
014506d to
5a4cb9c
Compare
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit 1415706)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit 1415706)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR makes a couple of updates to the encoding of the query source for SQL queries:
get_dftoget_sqla_engine.The reason for the later was there were a number of places where
get_sqla_enginewere being called without a source and it felt that this would be a better place to add the fallback logic if the source wasn't explicitly defined.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
CI and tested locally.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @villebro