Wrap <LoadableRenderer /> with <ErrorBoundary /> #6294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that since the introduction of <SuperChart />, errors in the visualization javascript (which are somewhat common and expected, especially as we'll support plugins) were not handled and the whole page would throw and go missing. Here I'm introducing a new <ErrorBoundary /> component that elegantly wraps other components and handles errors. It's inspired by: https://reactjs.org/docs/error-boundaries.html The default behavior of the component is to simply surface the error as an <Alert bsStyle="danger" /> and exposes the React stacktrace when clicking on the error. It's also possible to use component and pass an onError handler and not show the default message. This also fixes some minor bugs in TimeTable.
Codecov Report
@@ Coverage Diff @@
## master #6294 +/- ##
=========================================
- Coverage 77.01% 77% -0.02%
=========================================
Files 64 64
Lines 9508 9516 +8
=========================================
+ Hits 7323 7328 +5
- Misses 2185 2188 +3
Continue to review full report at Codecov.
|
kristw
reviewed
Nov 8, 2018
| const { | ||
| columnCollection, |
There was a problem hiding this comment.
Can do columnCollection = [] to default to []
kristw
reviewed
Nov 8, 2018
|
|
||
| componentDidCatch(error, info) { | ||
| this.props.onError(error, info); | ||
| this.setState({ hasError: true, error, info }); |
There was a problem hiding this comment.
Is hasError needed? Don't see it being used.
| const propTypes = { | ||
| children: PropTypes.node.isRequired, | ||
| onError: PropTypes.func, | ||
| showMessage: PropTypes.boolean, |
| queryResponse: PropTypes.object, | ||
| message: PropTypes.node.isRequired, | ||
| link: PropTypes.string, | ||
| stacktrace: PropTypes.string, |
There was a problem hiding this comment.
camelcase stackTrace for consistency with StackTraceMessage in the class name and showStackTrace.
|
+1 |
|
Oops I think there was a review collision here, I was addressing comments as this got merged. Sending an update. |
3 tasks
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* Wrap <LoadableRenderer /> with <ErrorBoundary /> It appears that since the introduction of <SuperChart />, errors in the visualization javascript (which are somewhat common and expected, especially as we'll support plugins) were not handled and the whole page would throw and go missing. Here I'm introducing a new <ErrorBoundary /> component that elegantly wraps other components and handles errors. It's inspired by: https://reactjs.org/docs/error-boundaries.html The default behavior of the component is to simply surface the error as an <Alert bsStyle="danger" /> and exposes the React stacktrace when clicking on the error. It's also possible to use component and pass an onError handler and not show the default message. This also fixes some minor bugs in TimeTable. * Addressing comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that since the introduction of , errors in the
visualization javascript (which are somewhat common and expected,
especially as we'll support plugins) were not handled and the whole
page would throw and go missing.
Here I'm introducing a new component that elegantly
wraps other
components and handles errors. It's inspired by:
https://reactjs.org/docs/error-boundaries.html
The default behavior of the component is to simply surface the error
as an and exposes the React stacktrace
when clicking on the error.
It's also possible to use component and pass an onError handler and not
show the default message.
This also fixes some minor bugs in TimeTable.