[superset-client] getClientErrorObject for everyone
#6276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
commented
Nov 5, 2018
| dispatch(annotationQuerySuccess(annotation, err, sliceKey)); | ||
| } else if (err.statusText !== 'abort') { | ||
| dispatch(annotationQueryFailed(annotation, err.responseJSON, sliceKey)); | ||
| dispatch(annotationQueryFailed(annotation, err, sliceKey)); |
There was a problem hiding this comment.
I verified that err.error is pulled from err in the annotationQueryFailed reducer
Codecov Report
@@ Coverage Diff @@
## master #6276 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 64 64
Lines 9504 9504
=======================================
Hits 7320 7320
Misses 2184 2184Continue to review full report at Codecov.
|
mistercrunch
approved these changes
Nov 5, 2018
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Nov 8, 2018
(cherry picked from commit 7fe8e8a) (cherry picked from commit c099382)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6272 and probably some other error 🐛 s that haven't been reported.
I searched for all instances of
SupersetClient.xxx().catch()and if any call attempted to pull an error message from theresponseI wrapped it in thegetClientErrorObjectwhich properly parses the response.Tested most of them manually by hand by inducing an error, here's the updated error for the reported bug:
@mistercrunch @kristw @michellethomas @graceguo-supercat