[lint] turn no-undef back on, set browser, cypress, and mocha env's #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
force-pushed
the
chris--lint-no-undef
branch
from
54ff031 to
f039524
Compare
|
Thanks for adding linting to cypress! 👍 |
michellethomas
approved these changes
Sep 13, 2018
kristw
approved these changes
Sep 13, 2018
williaster
force-pushed
the
chris--lint-no-undef
branch
from
f039524 to
8bf872b
Compare
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
…pache#5879) * [lint] turn no-undef back on, set browser, cypress, and mocha env's, and fix issues * [lint] fix undefined var in TimeTable.jsx
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns the
eslint no-undefrule back on because it's one of the more dangerous ones to have turned off 😈This resulted in
eslintcomplaining about various global variables, such aswindow(env: browser),cy(env: cypress), anddescribe(env: mocha). I added the appropriate.eslintrcs andenventries to setenvas appropriate, and removedmochaimports from tests because they are unnecessary.Also fixed ~10 bugs 🐛 from valid
no-undeferrors.@kristw @mistercrunch @michellethomas @graceguo-supercat