Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dashboard transition related config #5505

Conversation

graceguo-supercat
Copy link

a few lines in config file, used for dashboard v1 => v2 transition mode. Should be gone with #5418.

@williaster

@codecov-io
Copy link

Codecov Report

Merging #5505 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5505      +/-   ##
==========================================
- Coverage   63.38%   63.37%   -0.01%     
==========================================
  Files         349      349              
  Lines       22114    22110       -4     
  Branches     2455     2455              
==========================================
- Hits        14017    14013       -4     
  Misses       8083     8083              
  Partials       14       14
Impacted Files Coverage Δ
superset/config.py 92.3% <ø> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f87552...88cafd4. Read the comment docs.

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🥇

@graceguo-supercat graceguo-supercat merged commit 723bbe4 into apache:master Jul 27, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Aug 14, 2018
@graceguo-supercat graceguo-supercat deleted the gg-RemoveDashTransitionConfig branch August 14, 2018 22:55
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants