Apply SQL_QUERY_MUTATOR to explore & dashboard #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
changed the title
mistercrunch
force-pushed
the
SQL_QUERY_MUTATOR
branch
from
8b24a64 to
4e24c59
Compare
mistercrunch
force-pushed
the
SQL_QUERY_MUTATOR
branch
from
4e24c59 to
5a35c52
Compare
Codecov Report
@@ Coverage Diff @@
## master #5493 +/- ##
==========================================
+ Coverage 63.33% 63.36% +0.02%
==========================================
Files 349 349
Lines 22099 22113 +14
Branches 2455 2455
==========================================
+ Hits 13996 14011 +15
+ Misses 8089 8088 -1
Partials 14 14
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Jul 26, 2018
|
|
||
| def mutator(*args): | ||
| return '--COMMENT\n' + args[0] | ||
| app.config['SQL_QUERY_MUTATOR'] = mutator |
There was a problem hiding this comment.
I assume we're not running unit tests in parallel?
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
* Apply SQL_QUERY_MUTATOR kn explore & dashboard * Add unit test (cherry picked from commit 94cb20c)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 27, 2018
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 31, 2018
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
mistercrunch
added a commit
that referenced
this pull request
Aug 12, 2018
* Apply SQL_QUERY_MUTATOR kn explore & dashboard * Add unit test (cherry picked from commit 94cb20c)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Apply SQL_QUERY_MUTATOR kn explore & dashboard * Add unit test
mistercrunch
added
🍒 0.27.0
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* Apply SQL_QUERY_MUTATOR kn explore & dashboard * Add unit test (cherry picked from commit 94cb20c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL_QUERY_MUTATOR is a config parameter that allows for adding context as comments to SQL strings. This configuration callable was only called from SQL Lab, not from the explore view or dashboard view. Not it's applied in all cases.