Avoid expensive select_star on dashboard bootstrap data #5424
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dashboard page bootstrap data currently attempts to generate the `SELECT` statement with column name details for each table represented in the dash. This means it calls the database(s) and waits for column details prior to returning any HTML. This makes the default select_star property generate a simple `SELECT *` with no column details instead, which doesn't require interogating the DBs.
Codecov Report
@@ Coverage Diff @@
## master #5424 +/- ##
==========================================
- Coverage 59.1% 59.09% -0.02%
==========================================
Files 372 372
Lines 23747 23747
Branches 2758 2758
==========================================
- Hits 14036 14033 -3
- Misses 9696 9699 +3
Partials 15 15
Continue to review full report at Codecov.
|
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
The dashboard page bootstrap data currently attempts to generate the `SELECT` statement with column name details for each table represented in the dash. This means it calls the database(s) and waits for column details prior to returning any HTML. This makes the default select_star property generate a simple `SELECT *` with no column details instead, which doesn't require interogating the DBs.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
The dashboard page bootstrap data currently attempts to generate the `SELECT` statement with column name details for each table represented in the dash. This means it calls the database(s) and waits for column details prior to returning any HTML. This makes the default select_star property generate a simple `SELECT *` with no column details instead, which doesn't require interogating the DBs.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dashboard page bootstrap data currently attempts to generate the
SELECTstatement with column name details for each table representedin the dash. This means it calls the database(s) and waits for column
details prior to returning any HTML.
This makes the default select_star property generate a simple
SELECT *with no column details instead, which doesn't requireinterogating the DBs.
@betodealmeida