[DeckGL] Raise error with null values #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset/viz.py
Outdated
| @@ -2107,6 +2108,10 @@ def tupleify(s): | |||
| df[key] = list(zip(latlong.apply(lambda x: x[0]), | |||
| latlong.apply(lambda x: x[1]))) | |||
| del df[spatial.get('geohashCol')] | |||
|
|
|||
| if df[key] is None: | |||
There was a problem hiding this comment.
(optional)df.get(key) is None: would protect against KeyError (not sure if they're possible in this context)
superset/viz.py
Outdated
| @@ -2107,6 +2108,10 @@ def tupleify(s): | |||
| df[key] = list(zip(latlong.apply(lambda x: x[0]), | |||
| latlong.apply(lambda x: x[1]))) | |||
| del df[spatial.get('geohashCol')] | |||
|
|
|||
| if df[key] is None: | |||
| raise NullValueException('Some rows in this query contain NULL values!') | |||
There was a problem hiding this comment.
Msg could be a bit more precise and use i18n wrapper: _(Encountered invalid NULL spatial entry, please consider filtering those out)
There was a problem hiding this comment.
Is there a python lib for i18n? i thought is was only available for JS, i was searching the code for some example and couldn't find any.
There was a problem hiding this comment.
in this module it's available from the line from flask_babel import lazy_gettext as _
There was a problem hiding this comment.
the setup is kind of sweet where we use the same framework for both the backend and frontend.
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #5302 +/- ##
==========================================
+ Coverage 61.31% 61.32% +0.01%
==========================================
Files 369 369
Lines 23468 23488 +20
Branches 2717 2717
==========================================
+ Hits 14390 14405 +15
- Misses 9066 9071 +5
Partials 12 12
Continue to review full report at Codecov.
|
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 2, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
that referenced
this pull request
Jul 3, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
hughhhh
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 5, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
hughhhh
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
hughhhh
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
hughhhh
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 27, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 31, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting (cherry picked from commit 089037f)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* raise errors with null values * linting * linting some more * use get * change ordering * linting
mistercrunch
added
🍒 0.26.0
🍒 0.26.1
🍒 0.26.2
🍒 0.26.3
🍒 0.27.0
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really vague message with null values. Want to be more transparent about the errors in the underlying code for showing data in deckgl
@mistercrunch