Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard v2] add <MissingChart /> component #5296

Merged

Conversation

williaster
Copy link
Contributor

This PR adds a <MissingChart /> component that is shown in the case that a dashboard v2 <Chart /> component has no slice definition.

deleted-chart-flow

Testing

  • verified that this works in the case that a layout references a chart that was deleted (and previously part of the dashboard)
  • Added frontend tests for <MissingChart />
  • Tested undo/redo of removing the empty chart, adds toast when we add a slice that has no definition to a dashboard

@graceguo-supercat

@codecov-io
Copy link

Codecov Report

Merging #5296 into master will increase coverage by 0.7%.
The diff coverage is 86.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5296     +/-   ##
========================================
+ Coverage   61.29%     62%   +0.7%     
========================================
  Files         368     369      +1     
  Lines       23457   23981    +524     
  Branches     2716    2717      +1     
========================================
+ Hits        14379   14870    +491     
- Misses       9066    9099     +33     
  Partials       12      12
Impacted Files Coverage Δ
...set/assets/src/dashboard/actions/dashboardState.js 41.98% <0%> (-0.66%) ⬇️
...erset/assets/src/SqlLab/components/QuerySearch.jsx 68.18% <100%> (ø) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 83.13% <100%> (+0.41%) ⬆️
...t/assets/src/dashboard/components/MissingChart.jsx 100% <100%> (ø)
superset/viz.py 84.55% <0%> (+3.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee984c...a7a6d1c. Read the comment docs.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit 04fc1d1 into apache:master Jun 27, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Jun 27, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Jul 11, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Jul 11, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 26, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 26, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 26, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 27, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 31, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
…onent has no slice definition, add tests. (apache#5296)

(cherry picked from commit 04fc1d1)
mistercrunch pushed a commit that referenced this pull request Aug 12, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants