-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard v2] add <MissingChart />
component
#5296
[dashboard v2] add <MissingChart />
component
#5296
Conversation
…onent has no slice definition, add tests.
Codecov Report
@@ Coverage Diff @@
## master #5296 +/- ##
========================================
+ Coverage 61.29% 62% +0.7%
========================================
Files 368 369 +1
Lines 23457 23981 +524
Branches 2716 2717 +1
========================================
+ Hits 14379 14870 +491
- Misses 9066 9099 +33
Partials 12 12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (apache#5296) (cherry picked from commit 04fc1d1)
…onent has no slice definition, add tests. (#5296)
…onent has no slice definition, add tests. (apache#5296)
…onent has no slice definition, add tests. (apache#5296)
This PR adds a
<MissingChart />
component that is shown in the case that a dashboard v2<Chart />
component has no slice definition.Testing
<MissingChart />
@graceguo-supercat