[dashboard v2] misc UI fixes, undo redo bug fix #5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5293 +/- ##
=========================================
- Coverage 61.3% 61.3% -0.01%
=========================================
Files 368 368
Lines 23453 23455 +2
Branches 2713 2715 +2
=========================================
+ Hits 14378 14379 +1
- Misses 9063 9064 +1
Partials 12 12
Continue to review full report at Codecov.
|
williaster
changed the title
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jun 27, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 27, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 31, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners (cherry picked from commit 05a39b3)
mistercrunch
pushed a commit
that referenced
this pull request
Aug 12, 2018
…order (#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners
mistercrunch
added
🍒 0.27.0
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…order (apache#5293) * fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border * [dashboard v2] improve cached visual indicator, add last fetched messaging * [dashboard v2] fix ctrl + cmd + z + UndoRedoKeylisteners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following UI issues spotted in the new dashboard builder:
adds a check for
form_datain theChartcomponent container to prevent throwing ifchart.form_datais undefinedfixes a bug where our undo/redo event listeners considered 'z' a control key thus preventing users from adding a
zto headers + slice headers 😬removes red from cached data visual indicator and adds a label for the last-fetched time
before
after
fixes css for SQL lab
<Loading />instancebefore
after
refactors
AddSliceCardstyles to remove double marginbefore
after
@graceguo-supercat @john-bodley