pass error message separately #5194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
changed the title
timifasubaa
changed the title
timifasubaa
force-pushed
the
pass_error_link_separately
branch
from
04bac1d to
99a31d8
Compare
timifasubaa
force-pushed
the
pass_error_link_separately
branch
from
99a31d8 to
7fa5559
Compare
Codecov Report
@@ Coverage Diff @@
## master #5194 +/- ##
==========================================
- Coverage 63.46% 63.45% -0.01%
==========================================
Files 261 261
Lines 19835 19838 +3
Branches 1992 1995 +3
==========================================
Hits 12589 12589
- Misses 7237 7240 +3
Partials 9 9
Continue to review full report at Codecov.
|
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Jun 19, 2018
…ately pass error message separately (cherry picked from commit 4b7a14d)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…ately pass error message separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way error messages are passed to the frontend. In the past the HTML was sent from the backend but now it is passed separately in the JSON response.
@graceguo-supercat @michellethomas