[get_df] Adding support for multi-statement SQL #5086
Merged
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley-get-df-multi-statement-fix
branch
from
275ce03 to
eb4bed2
Compare
Codecov Report
@@ Coverage Diff @@
## master #5086 +/- ##
==========================================
+ Coverage 77.53% 77.53% +<.01%
==========================================
Files 44 44
Lines 8710 8713 +3
==========================================
+ Hits 6753 6756 +3
Misses 1957 1957
Continue to review full report at Codecov.
|
|
ping @michellethomas |
michellethomas
approved these changes
May 29, 2018
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
May 29, 2018
(cherry picked from commit 0511d1f)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
May 30, 2018
[get_df] Adding support for multi-statement SQL (apache#5086)
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch sorry I previously reverted #5060 as it didn't handle the case of statements including the
;character as part of a filter etc. Previously I was ignorantly splitting on the;character, whereas in this PR I use thesqlparsestdlib to parse the raw SQL which correctly identifies the statement(s).to: @betodealmeida @GabeLoins @michellethomas @mistercrunch