Override time grain in annotations #5084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding the time grain of time series annotations.
The good news is that we've unified the granularity of Druid and SQLAlchemy, using ISO duration strings, so we can apply the time grain of a Druid time series to a SQLAlchemy time series annotation, and vice versa.
The bad news is that this is currently a bit ugly because we don't know if the time series annotation has a SQLAlchemy or a Druid datasource. So we pass the current time grain in both
granularity
andtime_grain_sqla
. This only works if the SQLAlchemy datasource has a main temporal table configured.In the future we should unify this as a single parameter, IMHO.
The screenshot below shows an annotation that was saved with hourly grain (
sqla_hourly
) being loaded with daily grain. Note the new checkbox, "Override time grain":