[druid] Fixing Druid version check #5028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley-update-druid-version-checks
branch
from
1858264 to
649b013
Compare
john-bodley
force-pushed
the
john-bodley-update-druid-version-checks
branch
from
649b013 to
76cb4c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #5028 +/- ##
==========================================
- Coverage 77.34% 77.33% -0.01%
==========================================
Files 44 44
Lines 8665 8654 -11
==========================================
- Hits 6702 6693 -9
+ Misses 1963 1961 -2
Continue to review full report at Codecov.
|
|
ping @GabeLoins |
|
LGTM |
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigation another issue with @GabeLoins we realized that the Druid version check was invalid, i.e., per the comment on line #626 this issue was fixed in
0.8.2, yet the following conditionreturns
Truefor any version less than or equal to0.8.2rather than being exclusive of0.8.2since this is the version which included the fix. The same logic was wrong on line #646.The fix is to use
distutils.version.LooseVersionfor version checking which abides by Druid's semantic versioning.to: @GabeLoins @mistercrunch