[Explore] expanding regex for automated columns #4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellethomas
approved these changes
May 11, 2018
gabe-lyons
force-pushed
the
gabe_expanding_regex_for_autogenerated_columns
branch
from
95c3b8f to
c404aed
Compare
Codecov Report
@@ Coverage Diff @@
## master #4990 +/- ##
======================================
Coverage 77.1% 77.1%
======================================
Files 44 44
Lines 8636 8636
======================================
Hits 6659 6659
Misses 1977 1977Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autogenerated metrics can also be of the form AGGREGATE("table_name"."column_name"), here I expand the regex to cover such cases.
test plan:
reviewers:
@michellethomas @williaster @john-bodley @graceguo-supercat