Fix templating in sqla datasource [has migration] #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template parameters entered in SQL Lab were not persisted in the database. A new column template_params is added to the tables table, and is passed on to the template_kwargs prior to rendering.
|
LGTM apart from the build issues. |
Codecov Report
@@ Coverage Diff @@
## master #4971 +/- ##
==========================================
+ Coverage 77.03% 77.05% +0.02%
==========================================
Files 44 44
Lines 8595 8603 +8
==========================================
+ Hits 6621 6629 +8
Misses 1974 1974
Continue to review full report at Codecov.
|
mistercrunch
changed the title
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
Fix templating in sqla datasource [has migration]
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
Fix templating in sqla datasource [has migration]
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
Fix templating in sqla datasource [has migration]
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template parameters entered in SQL Lab were not persisted in the database. A new column template_params is added to the tables table and is passed on to the template_kwargs prior to rendering. Fixes #4970