Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] force flask<=1.0.0 #4959

Merged
merged 1 commit into from
May 13, 2018
Merged

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented May 8, 2018

flask 1.0 came out and has backwards incompatible changes. People
are reporting that fresh install doesn't work anymore.

fixes #4953

@john-bodley with most of our libs with no upper bound, any lib release backwards incompatible changes has the potential to break the pypi version. I'm not sure how to handle this. We could tell folks in our installation instruction to clone the repo and pip install -r requirements.txt but that seems wrong as we should make sure that a simple pip install superset just works. I understand that the downside of that approach is that limits users in which version of libs they may want to have the flexibility to run.

We should ship a 0.25.1 with this in.

flask 1.0 came out and has backwards incompatible changes. People
are reporting that fresh install doesn't work anymore.

fixes apache#4953

We should ship a 0.25.1 with this in
@codecov-io
Copy link

Codecov Report

Merging #4959 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4959   +/-   ##
=======================================
  Coverage   77.07%   77.07%           
=======================================
  Files          44       44           
  Lines        8558     8558           
=======================================
  Hits         6596     6596           
  Misses       1962     1962

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75df3d0...5de3e56. Read the comment docs.

@mistercrunch mistercrunch merged commit 2c5200a into apache:master May 13, 2018
@mistercrunch mistercrunch deleted the flask_pin branch May 13, 2018 18:16
mistercrunch added a commit that referenced this pull request May 14, 2018
flask 1.0 came out and has backwards incompatible changes. People
are reporting that fresh install doesn't work anymore.

fixes #4953

We should ship a 0.25.1 with this in

(cherry picked from commit 2c5200a)
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
flask 1.0 came out and has backwards incompatible changes. People
are reporting that fresh install doesn't work anymore.

fixes apache#4953

We should ship a 0.25.1 with this in
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
flask 1.0 came out and has backwards incompatible changes. People
are reporting that fresh install doesn't work anymore.

fixes apache#4953

We should ship a 0.25.1 with this in
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
flask 1.0 came out and has backwards incompatible changes. People
are reporting that fresh install doesn't work anymore.

fixes apache#4953

We should ship a 0.25.1 with this in
@mistercrunch mistercrunch added 🍒 0.25.1 🍒 0.25.2 🍒 0.25.3 🍒 0.25.4 🍒 0.25.5 🍒 0.25.6 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
flask 1.0 came out and has backwards incompatible changes. People
are reporting that fresh install doesn't work anymore.

fixes apache#4953

We should ship a 0.25.1 with this in

(cherry picked from commit e1590c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.25.1 🍒 0.25.2 🍒 0.25.3 🍒 0.25.4 🍒 0.25.5 🍒 0.25.6 🚢 0.26.0
Projects
None yet
3 participants