Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heatmap improvements #4897

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Heatmap improvements #4897

merged 1 commit into from
Apr 30, 2018

Conversation

mistercrunch
Copy link
Member

  • allow option to normalize the color distribution
  • make bounds work client side (instantaneous)
  • make more controls instantaneous

@mistercrunch
Heatmap improvements
2fda395 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous
@codecov-io
Copy link

codecov-io commented Apr 27, 2018 •
edited
Loading

Codecov Report

Merging #4897 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4897      +/-   ##
==========================================
+ Coverage   77.13%   77.14%   +<.01%     
==========================================
  Files          44       44              
  Lines        8542     8539       -3     
==========================================
- Hits         6589     6587       -2     
+ Misses       1953     1952       -1
Impacted Files Coverage Δ
superset/viz.py 79.9% <50%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f48c00...2fda395. Read the comment docs.

betodealmeida
betodealmeida approved these changes Apr 30, 2018
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can always use more instant controls. :)

@mistercrunch mistercrunch merged commit 3c7feb7 into apache:master Apr 30, 2018
@mistercrunch mistercrunch deleted the heat_heatmap branch April 30, 2018 16:36
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Apr 30, 2018
@mistercrunch
Heatmap improvements (apache#4897)
4b2f649 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request May 2, 2018
@mistercrunch
Heatmap improvements (apache#4897)
9849233 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request May 16, 2018
@mistercrunch @hughhhh
Heatmap improvements (apache#4897)
e91f156 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
@michellethomas
Copy link
Contributor

hey @mistercrunch it looks like this causes an issue with heatmaps that use Value Bounds with normalized turned off. The legend seems to respect the value bounds but the color doesn't change appropriately.

It also looks like without the value bounds the legend is always showing the normalized 0-1 range.

I can take a screenshot if the description is not clear. I'm testing on internal data so I'd just need to load test data.

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
Heatmap improvements (apache#4897)
54613ef 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request May 30, 2018
@mistercrunch
Heatmap improvements (apache#4897)
ecfd9c5 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request May 30, 2018
@mistercrunch
Heatmap improvements (apache#4897)
fa459aa 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
@mistercrunch @timifasubaa
Heatmap improvements (apache#4897)
ffc5d93 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jun 4, 2018
@mistercrunch
Heatmap improvements (apache#4897)
f9d774a 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Jun 7, 2018
@mistercrunch @hughhhh
Heatmap improvements (apache#4897)
f22d12f 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Jun 7, 2018
@mistercrunch @hughhhh
Heatmap improvements (apache#4897)
ea8e301 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Jun 7, 2018
@mistercrunch @hughhhh
Heatmap improvements (apache#4897)
c0b02bd 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jun 7, 2018
@mistercrunch
Heatmap improvements (apache#4897)
ff04e7c 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Jun 27, 2018
@mistercrunch @hughhhh
Heatmap improvements (apache#4897)
f3143a2 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous

(cherry picked from commit 3c7feb7)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
Heatmap improvements (apache#4897)
c4d9d0d 
* allow option to normalize the color distribution
* make bounds work client side (instantaneous)
* make more controls instantaneous
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistercrunch @codecov-io @michellethomas @betodealmeida