-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualization for multiple line charts #4819
Visualization for multiple line charts #4819
Conversation
…TOOLS-474_multiple_time_charts
Neat. I wonder if there is an easy way to align the ticks on both Y axes so they line up. Not a big deal but all those grey lines look a bit chaotic. If you Google image search “dual axis chart” you can see most tools out there align the ticks. |
…TOOLS-474_multiple_time_charts
…TOOLS-474_multiple_time_charts
which version do u change? |
i try to add a new visualization ,echarts_funnel,but it does not display in the types on the front ,my version is 0.24.0 . T.T |
Build is failing :( |
The build is failing due to conflicting numpy versions, not sure why that's happening. Will take another look, and also add an example. |
Will fix unit tests. |
Let's talk about what to do around filters, it may be easy to pass them as |
Codecov Report
@@ Coverage Diff @@
## master #4819 +/- ##
==========================================
+ Coverage 77.35% 77.41% +0.06%
==========================================
Files 44 44
Lines 8677 8701 +24
==========================================
+ Hits 6712 6736 +24
Misses 1965 1965
Continue to review full report at Codecov.
|
@mistercrunch, I removed the SQL and filter controls in the last commit. I'll do a separate PR handling them properly, accounting for multiple datasources. |
Cool, please fix merge conflicts, as this looks like it's ready to be merged. |
…TOOLS-474_multiple_time_charts
* Initial test * Save * Working version * Use since/until from payload * Option to prefix metric name * Rename LineMultiLayer to MultiLineViz * Add more styles * Explicit nulls * Add more x controls * Refactor to reuse nvd3_vis * Fix x ticks * Fix spacing * Fix for druid datasource * Rename file * Small fixes and cleanup * Fix margins * Add proper thumbnails * Align yaxis1 and yaxis2 ticks * Improve code * Trigger tests * Move file * Small fixes plus example * Fix unit test * Remove SQL and Filter sections
@mistercrunch , can you please let me know when this feature will be released? |
In 0.26.0, should be cut over the next week or two. |
* Initial test * Save * Working version * Use since/until from payload * Option to prefix metric name * Rename LineMultiLayer to MultiLineViz * Add more styles * Explicit nulls * Add more x controls * Refactor to reuse nvd3_vis * Fix x ticks * Fix spacing * Fix for druid datasource * Rename file * Small fixes and cleanup * Fix margins * Add proper thumbnails * Align yaxis1 and yaxis2 ticks * Improve code * Trigger tests * Move file * Small fixes plus example * Fix unit test * Remove SQL and Filter sections
* Initial test * Save * Working version * Use since/until from payload * Option to prefix metric name * Rename LineMultiLayer to MultiLineViz * Add more styles * Explicit nulls * Add more x controls * Refactor to reuse nvd3_vis * Fix x ticks * Fix spacing * Fix for druid datasource * Rename file * Small fixes and cleanup * Fix margins * Add proper thumbnails * Align yaxis1 and yaxis2 ticks * Improve code * Trigger tests * Move file * Small fixes plus example * Fix unit test * Remove SQL and Filter sections (cherry picked from commit 459cb70)
* Initial test * Save * Working version * Use since/until from payload * Option to prefix metric name * Rename LineMultiLayer to MultiLineViz * Add more styles * Explicit nulls * Add more x controls * Refactor to reuse nvd3_vis * Fix x ticks * Fix spacing * Fix for druid datasource * Rename file * Small fixes and cleanup * Fix margins * Add proper thumbnails * Align yaxis1 and yaxis2 ticks * Improve code * Trigger tests * Move file * Small fixes plus example * Fix unit test * Remove SQL and Filter sections (cherry picked from commit 459cb70)
* Initial test * Save * Working version * Use since/until from payload * Option to prefix metric name * Rename LineMultiLayer to MultiLineViz * Add more styles * Explicit nulls * Add more x controls * Refactor to reuse nvd3_vis * Fix x ticks * Fix spacing * Fix for druid datasource * Rename file * Small fixes and cleanup * Fix margins * Add proper thumbnails * Align yaxis1 and yaxis2 ticks * Improve code * Trigger tests * Move file * Small fixes plus example * Fix unit test * Remove SQL and Filter sections
* Initial test * Save * Working version * Use since/until from payload * Option to prefix metric name * Rename LineMultiLayer to MultiLineViz * Add more styles * Explicit nulls * Add more x controls * Refactor to reuse nvd3_vis * Fix x ticks * Fix spacing * Fix for druid datasource * Rename file * Small fixes and cleanup * Fix margins * Add proper thumbnails * Align yaxis1 and yaxis2 ticks * Improve code * Trigger tests * Move file * Small fixes plus example * Fix unit test * Remove SQL and Filter sections
This PR adds a new viz type,
line_multi
. It's similar to the Deck.gl multi, in that it combines different saved charts (of lines) into a single chart. Here's an example combining two charts, one of them with a group by:The viz works by fetching all the data for each chart in parallel (in Javascript), and passing the payload to the
nvd3Vis
function. Different time series are padded withnull
at the edges to bypass a bug inmultiChart
when timeseries have different ranges forx
.One thing I did in this PR was add a
sectionOverrides
config invisTypes.js
, so that the datasource selector is not shown in this viz (I'll add it to the Deck.gl multi in a next PR, or I can do it in this one).