-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[explore] forcing .1% number format when using 'Period Ratio' #4774
Conversation
mistercrunch
commented
Apr 6, 2018
Codecov Report
@@ Coverage Diff @@
## master #4774 +/- ##
==========================================
- Coverage 72.59% 72.57% -0.03%
==========================================
Files 205 205
Lines 15401 15407 +6
Branches 1183 1189 +6
==========================================
+ Hits 11180 11181 +1
- Misses 4218 4223 +5
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mistercrunch, can you give more context here? Is there no reason to have a different format when using "Period Ratio"?
Oh the idea is that when using a period ratio, we're looking at a % change, so we should change the format should reflect that. Since we know it's a percentage we can just format it on their behalf. There's no precedent into cascading control changes based on rules, here we just force the format to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, sounds and looks good!
…sing Period Ratio (apache#4774)