Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brush with annotations #4773

Merged

Conversation

betodealmeida
Copy link
Member

The brush (time filter) currently does not work with annotations:

brush_before

I added a new callback that is dispatched when the brush is updated, and now it works:

brush_after

@codecov-io
Copy link

codecov-io commented Apr 6, 2018

Codecov Report

Merging #4773 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4773   +/-   ##
=======================================
  Coverage   72.59%   72.59%           
=======================================
  Files         205      205           
  Lines       15401    15401           
  Branches     1183     1183           
=======================================
  Hits        11180    11180           
  Misses       4218     4218           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92230b8...b223abe. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM.

Leaving a bit more time if other committers want to take a look

@mistercrunch mistercrunch merged commit 1a26485 into apache:master Apr 6, 2018
@mistercrunch mistercrunch deleted the DPTOOLS-452_fix_brush_with_annotations branch April 6, 2018 23:18
@ahsanshah
Copy link

ahsanshah commented May 20, 2018

Hi, I am on v0.25.5 and it seems this fix is intermittently showing up. For instance, when I initially create/save a slice with 1 or more annotations, it works fine with the range brush. However, if I save or retest on a dashboard that contains the slice it shows 2 overlapping layers of annotations. One that moves with the brush and one that is static.

Any idea why this may be. Is this part of a different release? Here is a picture.

image

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* Make annotation work with brush

* Add dispatch for events

* Fix lint

* Use xScale.clamp
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
* Make annotation work with brush

* Add dispatch for events

* Fix lint

* Use xScale.clamp
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Make annotation work with brush

* Add dispatch for events

* Fix lint

* Use xScale.clamp
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants