-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix brush with annotations #4773
Fix brush with annotations #4773
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4773 +/- ##
=======================================
Coverage 72.59% 72.59%
=======================================
Files 205 205
Lines 15401 15401
Branches 1183 1183
=======================================
Hits 11180 11180
Misses 4218 4218
Partials 3 3 Continue to review full report at Codecov.
|
LGTM. Leaving a bit more time if other committers want to take a look |
Hi, I am on v0.25.5 and it seems this fix is intermittently showing up. For instance, when I initially create/save a slice with 1 or more annotations, it works fine with the range brush. However, if I save or retest on a dashboard that contains the slice it shows 2 overlapping layers of annotations. One that moves with the brush and one that is static. Any idea why this may be. Is this part of a different release? Here is a picture. |
* Make annotation work with brush * Add dispatch for events * Fix lint * Use xScale.clamp
* Make annotation work with brush * Add dispatch for events * Fix lint * Use xScale.clamp
* Make annotation work with brush * Add dispatch for events * Fix lint * Use xScale.clamp
The brush (time filter) currently does not work with annotations:
I added a new callback that is dispatched when the brush is updated, and now it works: