[sqllab] fix data grid's instant search function #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like any non-string type would break the search feature. of `FilterableTable`
hughhhh
reviewed
Mar 29, 2018
| return metrics.width; | ||
| if (context) { | ||
| // Won't work outside of a browser context (ie unit tests) | ||
| context.font = fontDetails; |
There was a problem hiding this comment.
nit: context = {...context, font: fontDetails}
There was a problem hiding this comment.
i don't think that works for objects with methods...
There was a problem hiding this comment.
I tested it in my console:
> test_obj = { my_func: () => 'test'}
{ my_func: [Function: my_func] }
> new_test_obj = {...test_obj}
{ my_func: [Function: my_func] }
> new_test_obj
{ my_func: [Function: my_func] }
> new_test_obj.my_func()
'test'
It seems like it works, but no biggie if you want to keep it as is. I'm not 💯% sure it won't break at runtime
There was a problem hiding this comment.
I meant prototype "inherited" funcs
hughhhh
reviewed
Mar 29, 2018
| // Won't work outside of a browser context (ie unit tests) | ||
| context.font = fontDetails; | ||
| const metrics = context.measureText(text); | ||
| return metrics.width; |
There was a problem hiding this comment.
nit: just return context.measureText(text).width
|
🚢 |
mistercrunch
force-pushed
the
fix_sqllab_search
branch
from
31db249 to
8d01cd5
Compare
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* [sqllab] fix data grid's instant search function It looks like any non-string type would break the search feature. of `FilterableTable` * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* [sqllab] fix data grid's instant search function It looks like any non-string type would break the search feature. of `FilterableTable` * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* [sqllab] fix data grid's instant search function It looks like any non-string type would break the search feature. of `FilterableTable` * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* [sqllab] fix data grid's instant search function It looks like any non-string type would break the search feature. of `FilterableTable` * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* [sqllab] fix data grid's instant search function It looks like any non-string type would break the search feature. of `FilterableTable` * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 4, 2018
* [sqllab] fix data grid's instant search function It looks like any non-string type would break the search feature. of `FilterableTable` * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 11, 2018
* [sqllab] fix data grid's instant search function It looks like any non-string type would break the search feature. of `FilterableTable` * Addressing comments
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [sqllab] fix data grid's instant search function It looks like any non-string type would break the search feature. of `FilterableTable` * Addressing comments
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* [sqllab] fix data grid's instant search function It looks like any non-string type would break the search feature. of `FilterableTable` * Addressing comments
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [sqllab] fix data grid's instant search function It looks like any non-string type would break the search feature. of `FilterableTable` * Addressing comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like any non-string type would break the search feature.
of
FilterableTable.closes #4713