Preprocess SQL Lab query prior to checking syntax #4686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syntax checking doesn't work if jinja templates haven't been prerendered. Also remove unreachable return statement. Fixes #4288.
|
Testing for this would require calling sql_lab.execute_query(), as the error arises when syntax checking happens prior to calling the template processor. Currently there doesn't seem to be a unit test for this function. If the maintainers see the need for one for this specific case, I can add one. |
Codecov Report
@@ Coverage Diff @@
## master #4686 +/- ##
=========================================
+ Coverage 71.4% 71.4% +<.01%
=========================================
Files 190 190
Lines 14935 14934 -1
Branches 1102 1102
=========================================
Hits 10664 10664
+ Misses 4268 4267 -1
Partials 3 3
Continue to review full report at Codecov.
|
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Mar 29, 2018
Syntax checking doesn't work if jinja templates haven't been prerendered. Also remove unreachable return statement. Fixes apache#4288. (cherry picked from commit 4ec8258)
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Mar 30, 2018
Syntax checking doesn't work if jinja templates haven't been prerendered. Also remove unreachable return statement. Fixes apache#4288. (cherry picked from commit 4ec8258)
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Mar 30, 2018
Syntax checking doesn't work if jinja templates haven't been prerendered. Also remove unreachable return statement. Fixes apache#4288. (cherry picked from commit 4ec8258)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
Syntax checking doesn't work if jinja templates haven't been prerendered. Also remove unreachable return statement. Fixes apache#4288.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
Syntax checking doesn't work if jinja templates haven't been prerendered. Also remove unreachable return statement. Fixes apache#4288.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax checking doesn't work if jinja templates haven't been prerendered.
Also remove unreachable return statement. Fixes #4288.