[sql lab] search to use fist&last name instead of username #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our environment username are not readable coming out of oauth, so we'd rather use first&last when available.
mistercrunch
force-pushed
the
search_usernames
branch
from
a7c1f8a to
c5a78fd
Compare
Codecov Report
@@ Coverage Diff @@
## master #4628 +/- ##
==========================================
+ Coverage 71.22% 71.23% +0.01%
==========================================
Files 190 190
Lines 14884 14904 +20
Branches 1099 1100 +1
==========================================
+ Hits 10601 10617 +16
- Misses 4280 4284 +4
Partials 3 3
Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
In our environment username are not readable coming out of oauth, so we'd rather use first&last when available.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
In our environment username are not readable coming out of oauth, so we'd rather use first&last when available.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our environment username are not readable coming out of oauth, so
we'd rather use first&last when available.
Also a bit of refactoring on
QuerySearch.jsx