[Bug Fix] Making timeseries_limit not required for phase 2 #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4581 +/- ##
==========================================
+ Coverage 71.17% 71.17% +<.01%
==========================================
Files 187 187
Lines 14809 14810 +1
Branches 1085 1085
==========================================
+ Hits 10540 10541 +1
Misses 4266 4266
Partials 3 3
Continue to review full report at Codecov.
|
|
@mistercrunch would you mind reviewing this PR? It seems like you have the most context here. |
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 13, 2018
(cherry picked from commit 1d0ec9f)
mistercrunch
pushed a commit
that referenced
this pull request
Mar 13, 2018
(cherry picked from commit 1d0ec9f)
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Mar 13, 2018
(cherry picked from commit 1d0ec9f)
michellethomas
changed the title
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 1, 2018
* Cherry pick apache#4581 * Add flask-compress cherry * Add shortner fix * Add Return __time in Druid scan apache#4504 * Picking cherry Fixing regression from apache#4500 (apache#4549) * [bugfix] SQL Lab 'MySQL has gone away' It appears the 'MySQL has gone away' is triggered by the line of code I wrapped in a try block here. This is a temporary fix, there will be another PR shortly getting to the bottom of this. Related: https://github.com/lyft/druidstream/issues/40
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🍒 0.23.3
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 1d0ec9f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue on time series group by queries, if the chart doesn't have a limit, the data is incorrect. It gets run as a phase 1 query and shows only a single datapoint for each group by value instead of listing the full timeseries data.
It looks like this was added here, but I don't think queries without a limit should automatically be phase 1. I changed this but I'm not quite sure why it was added, is this needed for deckgl viz types?
I tested this on time series phase 2 queries and phase 1 without a limit, and tested bar and pie chart visualizations.
Fixes #4208
@mistercrunch @john-bodley