[Explore] applying refresh chart overlay when chart is stale #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
changed the title
graceguo-supercat
requested changes
Feb 26, 2018
There was a problem hiding this comment.
To me refresh means your new query generates new data, chart is inconsistent with latest query.
But when your control is messed up, you can not make a new query, so there is no new query results. Refresh chart doesn't make sense, and not necessary since old chart is still valid.
| disabled={!!this.props.errorMessage} | ||
| bsStyle={this.props.errorMessage ? 'danger' : 'primary'} | ||
| > | ||
| <i className="fa fa-bolt" /> Refresh Chart |
| @@ -424,3 +428,12 @@ g.annotation-container { | |||
| content: "\f0dd"; | |||
| color: @brand-primary; | |||
| } | |||
|
|
|||
| .refresh-chart-overlay { | |||
There was a problem hiding this comment.
We could use a more general name if we want to reuse that style for the loading spinner
gabe-lyons
force-pushed
the
gabe_applying_refresh_chart_overlay_when_chart_is_stale
branch
from
a0ecc2e to
c96ef64
Compare
|
@graceguo-supercat addressed the comments that came up in the team meeting- PTAL again! |
gabe-lyons
force-pushed
the
gabe_applying_refresh_chart_overlay_when_chart_is_stale
branch
from
7132b07 to
a9d2616
Compare
graceguo-supercat
previously requested changes
Feb 27, 2018
gabe-lyons
force-pushed
the
gabe_applying_refresh_chart_overlay_when_chart_is_stale
branch
from
a9d2616 to
9cb7d03
Compare
graceguo-supercat
approved these changes
Feb 28, 2018
hughhhh
added a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 9, 2018
…pache#4486)" This reverts commit 764a92c.
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…4486) * adding refresh chart overlay when chart is out of sync with control panel * fading the visualization when stale * addressing comments from team on layout of UI
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…4486) * adding refresh chart overlay when chart is out of sync with control panel * fading the visualization when stale * addressing comments from team on layout of UI
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #4459 to make it more obvious when the chart should be refreshed.
after making a change affecting the query:
dismissing the overlay still keeps the run button highlighted:
but if you make a change causing errors no overlay appears:
test plan:
reviewers:
@graceguo-supercat @michellethomas @mistercrunch