Adding dashboard add view #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
reviewed
Feb 6, 2018
superset/views/core.py
Outdated
| @@ -507,6 +507,7 @@ class SliceAddView(SliceModelView): # noqa | |||
| list_columns = [ | |||
| 'id', 'slice_name', 'slice_link', 'viz_type', | |||
| 'datasource_link', 'owners', 'modified', 'changed_on'] | |||
| show_columns = SliceModelView.edit_columns + list_columns | |||
There was a problem hiding this comment.
This seems prone to have duplicated columns, is this not an issue?
There was a problem hiding this comment.
It didn't cause an issue for me, but I agree it would be a good idea to dedupe. Fixed.
john-bodley
approved these changes
Feb 6, 2018
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
Feb 6, 2018
* Adding DashboardAddView and setting show_columns on SLiceAddView * Adding tests for sliceaddview read api * Dedupe show_columns
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Adding DashboardAddView and setting show_columns on SLiceAddView * Adding tests for sliceaddview read api * Dedupe show_columns
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Adding DashboardAddView and setting show_columns on SLiceAddView * Adding tests for sliceaddview read api * Dedupe show_columns
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using the flask app builder apis to programmatically create slices and dashboards, but when posting to
sliceaddview/api/createordashboardmodelview/api/createthe result doesn't include fields that are useful. They both don't include theidof the dashboard or slice created (which makes it difficult to keep track of).show_columns is the field that determines what data gets returned after a request, so I'm adding additional fields to show_columns.
SliceAddView already exists and is being used to get all slices for a user, so because I don't want to introduce any future issues I'm adding tests for sliceaddview.
@john-bodley