[API] Deprecate unnecessary /update_role/ API endpoint #4041
+0
−126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
/update_role/
API endpoint which it seems was added specifically for an Airbnb use case. The endpoint appends users (new or existing) to a role which is invoked for syncing external permissions. The issue with this approach is it merely grants permissions and never revokes.This use case seems very tailored, and thus rather than adding additional API endpoints to removes users it seems a more prudent approach would be to leverage the FAB REST API. Specifically the same functionality can be achieved via something of the form,
which defines the set of users (via primary key) associated with the
Alpha
role. This method provides the ability to add or remove users since the the user list defines the complete set of users associated with said role.to: @mistercrunch