Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[viz] Fix payload force logic #3839

Merged

Conversation

john-bodley
Copy link
Member

The logic to force fetch the visualization payload is specified via the force request argument rather than the force key in the form-data.

Note the form-data serves as the cache key and thus if this logic were correct the force field would need to be removed from cache_key, i.e., the key should be agnostic of forcing function.

@coveralls
Copy link

coveralls commented Nov 12, 2017

Coverage Status

Coverage decreased (-0.004%) to 71.513% when pulling 95b6515 on john-bodley:john-bodley-fix-payload-force into 4d48d5d on apache:master.

@mistercrunch
Copy link
Member

Yeah that's an artifact of the era where form_data was the actual query string as opposed to serialized json

@mistercrunch mistercrunch merged commit a3a4687 into apache:master Nov 12, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants