New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8] Enabling flake8 linting #3776

Merged

mistercrunch merged 1 commit into apache:master from john-bodley:john-bodley-enable-flake8

Nov 5, 2017

Member

john-bodley commented Nov 5, 2017 •

edited

Loading

I felt it would be prudent to add additional linting to the Python code beyond pylint ensures to help enforce a consistent style.

This PR enables flake8 as part of the Travis CI though currently all errors which were triggered have been whitelisted to be ignored. My plan is to systematically address these errors via a series of digestible PRs in the coming days/weeks.

Note I deprecated pycodestyle as this flake8 is a superset of pep8.

to: @mistercrunch
cc: @graceguo-supercat @michellethomas @timifasubaa

john-bodley force-pushed the john-bodley-enable-flake8 branch 2 times, most recently from 85c000b to 3bc1383 Compare

November 5, 2017 02:06

coveralls commented Nov 5, 2017 •

edited

Loading

Coverage remained the same at 71.271% when pulling 85c000bcc0d1f65b6d4d70c6d0f549d46021528e on john-bodley:john-bodley-enable-flake8 into 8e3217a on apache:master.

coveralls commented Nov 5, 2017 •

edited

Loading

Coverage remained the same at 71.271% when pulling 3bc1383b4a7635fa943b87125ff0965d0c1e5861 on john-bodley:john-bodley-enable-flake8 into 8e3217a on apache:master.

coveralls commented Nov 5, 2017 •

edited

Loading

Coverage remained the same at 71.271% when pulling 3bc1383b4a7635fa943b87125ff0965d0c1e5861 on john-bodley:john-bodley-enable-flake8 into 8e3217a on apache:master.

2 similar comments

coveralls commented Nov 5, 2017

Coverage remained the same at 71.271% when pulling 3bc1383b4a7635fa943b87125ff0965d0c1e5861 on john-bodley:john-bodley-enable-flake8 into 8e3217a on apache:master.

coveralls commented Nov 5, 2017

Coverage remained the same at 71.271% when pulling 3bc1383b4a7635fa943b87125ff0965d0c1e5861 on john-bodley:john-bodley-enable-flake8 into 8e3217a on apache:master.

john-bodley force-pushed the john-bodley-enable-flake8 branch from 3bc1383 to b32318a Compare

November 5, 2017 04:18


          [flake8] Enabling flake8 linting

d4b8558

john-bodley force-pushed the john-bodley-enable-flake8 branch from b32318a to d4b8558 Compare

November 5, 2017 04:21

coveralls commented Nov 5, 2017

Coverage remained the same at 71.271% when pulling d4b8558 on john-bodley:john-bodley-enable-flake8 into 8e3217a on apache:master.

3 similar comments

coveralls commented Nov 5, 2017

Coverage remained the same at 71.271% when pulling d4b8558 on john-bodley:john-bodley-enable-flake8 into 8e3217a on apache:master.

coveralls commented Nov 5, 2017

Coverage remained the same at 71.271% when pulling d4b8558 on john-bodley:john-bodley-enable-flake8 into 8e3217a on apache:master.

coveralls commented Nov 5, 2017

Coverage remained the same at 71.271% when pulling d4b8558 on john-bodley:john-bodley-enable-flake8 into 8e3217a on apache:master.

coveralls commented Nov 5, 2017 •

edited

Loading

Coverage remained the same at 71.271% when pulling d4b8558 on john-bodley:john-bodley-enable-flake8 into 8e3217a on apache:master.

mistercrunch merged commit 13c17e1 into apache:master

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request


          [flake8] Enabling flake8 linting (apache#3776)

21f1e46

wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request


          [flake8] Enabling flake8 linting (apache#3776)

ef4c038

mistercrunch added 🏷️ bot 🚢 0.20.5 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot 🚢 0.20.5