[time table] add tooltip to sparkline #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,13 +54,12 @@ function viz(slice, payload) { | |||
| } | |||
| const tableData = metrics.map((metric) => { | |||
| let leftCell; | |||
| const context = Object.assign({}, fd, { metric }); | |||
| const url = fd.url ? Mustache.render(fd.url, context) : null; | |||
There was a problem hiding this comment.
Why was Mustache removed? The url needs to be rendered with the context (to interpret something like {{ metric }}).
There was a problem hiding this comment.
ohhh, yeah I didn't understand what this was doing fully/thought it was forcing the url to be within the app. added it back.
|
this lgtm |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [time table] add tooltip to sparkline * [time table] open link in new tab * [time table] add back Mustache
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [time table] add tooltip to sparkline * [time table] open link in new tab * [time table] add back Mustache
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch @graceguo-supercat
This PR
@data-ui/sparklineto0.0.47where I added tooltip supportTested sparkline functionally (see screenshot) and tested url opening in new tab functionally for group by + non-group by combos, and with new mocha test