fix: always fetch database list on bootstrap payload #11934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was this weird bug happening only when `SQLLAB_BACKEND_PERSISTENCE = False` where if no database had been selected, there would be some issue. This makes sure that the store is populated consistently with the list of database connections regardless of `SQLLAB_BACKEND_PERSISTENCE`. It also uses the DAO to fetch database and will apply the RBAC-related filters if any, the same way that the API does.
6 tasks
mistercrunch
commented
Dec 4, 2020
| @@ -76,6 +76,19 @@ def find_by_ids(cls, model_ids: List[int]) -> List[Model]: | |||
| ).apply(query, None) | |||
| return query.all() | |||
|
|
|||
| @classmethod | |||
| def find_all(cls) -> List[Model]: | |||
There was a problem hiding this comment.
I know this is very similar to find_by_ids but decided to go explicit over dry. We're already pretty meta here so didn't want to add a layer to safe a few lines of code.
Codecov Report
@@ Coverage Diff @@
## master #11934 +/- ##
==========================================
- Coverage 67.64% 63.59% -4.05%
==========================================
Files 932 464 -468
Lines 45211 28532 -16679
Branches 4333 0 -4333
==========================================
- Hits 30583 18145 -12438
+ Misses 14525 10387 -4138
+ Partials 103 0 -103
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was this weird bug happening only when
SQLLAB_BACKEND_PERSISTENCE = Falsewhere if no database had been selected, there would be someissue.
This makes sure that the store is populated consistently with the list
of database connections regardless of
SQLLAB_BACKEND_PERSISTENCE. Italso uses the DAO to fetch database and will apply the RBAC-related
filters if any, the same way that the API does.
@dpgaspar @hughhhh @betodealmeida