raise exception early

apache · May 18, 2018 · f52f7aa · f52f7aa
1 parent cf374ef
commit f52f7aa
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/superset/views/core.py b/superset/views/core.py
@@ -1232,7 +1232,10 @@ def datasource_info(datasource_id, datasource_type, form_data):
             # The case where the datasource has been deleted
             datasource_id = None if datasource_id == 'None' else datasource_id
 
-        datasource_id = int(datasource_id) if datasource_id else None
+        if not datasource_id:
+            raise Exception(
+                'The data source associated with this chart no longer exists')
+        datasource_id = int(datasource_id)
         return datasource_id, datasource_type
 
     @log_this