-
Notifications
You must be signed in to change notification settings - Fork 8.8k
20240302‐EN
Meeting Host: @Jiangke Wu(xingfudeshi)
Attendees (PPMC only, see Appendix for other attendees):@Jiangke Wu、@Min Ji、@Jianbin Chen、@Liang Wang、@Te Wang、@Yuecai Liu、@Qiufeng Liu、@Xiangkun Yin、@Jiawei Zhang
Next biweekly meeting:
- Time:
2024/3/16
. (If there are any changes, we will notify separately. Please follow the email-list:[email protected]
,[email protected]
) - Host: @Yuecai Liu(luky116)
- Discussion on Library Migration Scope @Jimin done
- Seata Java, seata go, k8s, ctl @DongJunduo, official website, simple (Java, go)
- ASF ICLA contributor signature: @Jimin
- Public email template done
- Contact the corresponding developer Done via email after database migration
- Review email template: @Jimin
- Provide review email template writing
- Feedback with issues
- Incubation progress synchronization @Jimin
- The legal issue has been resolved, don
- Reported to Apache Secretary Done
- Supplementary documents: Development history done, user guide @YinXiangkun, configuration document split @ChenJianbin, upgrade document split @ChenJianbin, deployment document split @ChenJianbin @Jimin @YinXiangkun
- Usage guide split completed (completed, go to be completed)
- Upgrade document split completed (completed)
- Configuration document (completed) (Jianbin), deployment document ✅
- Collect contributor information with contributions greater than 100 lines and trace it back to @Yunqing done
- It has been sent to the DingTalk group, with 16 such
@users.noreply.github.com
emails; And 17 people who couldn't find their email;
- It has been sent to the DingTalk group, with 16 such
- Compliance and security @LiuQiufeng @Jimin done
- The default language has been changed to English; Done
- The official website has added license check, dependency check, license, and URL updates; Done
- The commercial link has been removed; Done
- The maintainer list has been removed; Done
- The security vulnerabilities on the official website have been fixed; Done
- User registration removal; Done
- Note: It is not allowed to have significantly the same code as other Apache repositories
- Baidu search traffic decline issue (according to
seata.apache.org
, notseata.io
) @LiuQiufeng- The automatic generation of
sitemap.xml
andsite.txt
by CI has been completed - The content pre rendering transformation has been completed
- The API's automatic reporting to Baidu function has been completed, but the amount given by Baidu is very small
- The automatic generation of
- Abandon the language sparrow; Migration of historical documents to wiki @LiuYuecai @Yixia @SummerCodeTutor
- Scattered documents do not migrate done
- Design, extracurricular materials, and other documents need to be migrated (Java, go merged with seata main repository wiki storage) done
- New directory storage (completed)
- Migration of documents related to summer code to the corresponding directory (priority given to project completion in this year's plan design) @ChenJianbin @WangLiang @LiuYuecai done
- The design documents/open source summer have all been migrated; There is no need to migrate the weekly meeting, just give the old address to the wiki;
- Single test coverage target @Jiawei @WangZhongxiang
-
seata-core
@WangZhongxiang done -
seata-common
@Jiawei done
-
- Disposal of backlog PR @ChenJianbin @LiuYuecai
- Java: Unmanned items before May 2022 have been closed and left messages, except for some important ones (completed)
- 1.8.0 + 2.0.0 documentation, releaseNotes, and samples updates @Yixia
- 1.8.0 + 2.0.0 releaseNotes done
- Email sending standards, same transaction mode, one business scenario @Yixia Done
- Branch maintenance. Maintenance plan public document @JiangJunmin done
- Maintain by version, only maintain the last 3 versions (including the latest version) merge, done
- Compatibility plan for new and old warehouses. Sort out APIs, @YinXiangkun (already sorted out, to be discussed separately)
- User API sorting, Saga completed (12.9), done (12.23) @YinXiangkun done
- Compatibility testing (JDK, Arch, Spring core+boot, Druid) @WangLiang
- OS, JDK, Spring Boot, Compatibility Test PR, Completed
- Separate workflows to improve parallelism; Don't do it for now.
- Confirm the use of TCC and whether it is necessary to be compatible with special usage methods @Yixia @Zongjie (follow up with relevant PR)
- Unified specification: The Java TCC annotation standard is unified and printed on the implementation class. After completing the rm annotation, it needs to be disclosed in the document. In addition, the
LocalTCC
annotation should be discarded and the TwoPhase annotation should also be used; Done
- Unified specification: The Java TCC annotation standard is unified and printed on the implementation class. After completing the rm annotation, it needs to be disclosed in the document. In addition, the
- Baidu search traffic decline issue (according to
seata.apache.org
, notseata.io
) @LiuQiufeng- Ranking has increased and the official website is at the top. Done (old domain name, completed)
- Package migration:
io.seata
->org.apache.seata
- Merge the current PR as soon as possible and handle it uniformly @Jimin done 2/3
- Mock test @Minghua (4 PR have been submitted, awaiting review merge)
- Preliminary review has been conducted. Next week, a separate PR will be provided for mock server, and some content will mention sea samples
- Add test cases @Minghua (PR has been merged, but single testing often fails and needs to be reviewed again to see if it can be put into use) (@Jimin trace)
-
- PPMC's understanding of Apache policies and compliance needs to be improved
-
- Try to use email and communicate in English as much as possible
-
- Registration for the competition, due tomorrow at 1.21 (Performance Competition Function Design), everyone is actively participating
-
- Task lists, etc. can be sent to email groups:
- Vulnerability
-
Compliance and security @LiuQiufeng @Jimin doing
-
Logo renovation:@LiuQiufeng done
-
English blog; From 0 to 1; Translate the existing one; Todo @Yunqing has completed 16 articles, and all article title placeholders have been added. There are still 30-40 articles @Yuanxin, and more than 10 have been completed in the past two weeks; (Expected to be completed in 1-1.5 months)
-
41 front-end security vulnerabilities @Jimin, awaiting review merge, (2/3: 18 remaining vulnerabilities remain unresolved)
-
Seata go has 5 remaining vulnerabilities @Yixia Monthly financial target next week (all fixed) done
-
There are still 125 seata samples left. @Yixia Also to be launched in summer, with pre dependencies (PR has been submitted, create a new branch, merge it first, and run to see if there are any problems) @Jimin to be confirmed
- Simple is running in a new format, and the code specifications need to be compatible and modified @Yixia
-
https://github.com/apache/incubator-seata/discussions/6233
Compliance related issues
- External link: @LiuQiufeng @Jimin
- Apache Logo: Add Apache elements to the logo of Seat.
-
Basic work completed:
- Next week, the first round of acceptance will be conducted by the supervisor. An email has been sent and the supervisor has reviewed it, leaving only the two issues discussed above.
- Problem: The domain name of the official website document has not been switched. The introduction of slogan's seata in the first month has been improved in the origin section @Jimin @LiuQiufeng done
-
Part of page 301 redirects to 404 Not Found: @LiuQiufeng @Jimin
- Overall solution: @Jimin
- Gateway:
- Nginx:
- PR:
- https://seata.apache.org/zh-cn/docs/overview/what-is-seata.html (PR submitted) @LiuQiufeng
- Overall solution: @Jimin
-
When adding a node to a cluster, it is necessary to verify whether the node is legal: @ChenJianbin (2/3 new)
-
There are also two external chain issues; There are 3 vulnerabilities on the official website and about 20 vulnerabilities on the backend; Most of the work has been completed; Gradually improve in the future
-
-
Baidu search traffic decline issue (according to
seata.apache.org
, notseata.io
) @LiuQiufeng- Official website keyword optimization (long-term): The first two weeks have not been processed yet, and we will work together to improve the page experience in the future
- Improve page experience score; Todo (Phase 2; Phase 1 focuses on compliance first;
- There is an issue with the jump format. The link under the new domain name needs to be manually submitted for modification, and a quick migration process is required. URL mapping
- The description of the official website found on Baidu, content optimization, and current effects are shown in three screenshots: (priority processing)
-
1.8.0 + 2.0.0 documentation, releaseNotes, and samples updates @Yixia
- Java sample (new version not yet released, no need to upgrade), seata version upgraded to 2.0, public logic optimization, progress completed 7, 40%. (PR has been submitted, but further optimization is needed)
-
Compatibility plan for new and old warehouses. Sort out APIs, @YinXiangkun (already sorted out, to be discussed separately)
- State Machine Designer Framework Selection and Basic Framework (12.9) First Version Completed (12.23) (PR Completed, awaiting review; after individual branch development is completed, submit to 2. x branch separately) @YinXiangkun
- Sorting completed, currently being implemented;
-
Log optimization: (Overall progress: less than 20%) (@Jimin PR has been submitted and meets the requirements of internationalization. The stack generated has corresponding errorCode, and a link chain will be displayed in the error message to the FAQ page.)
- Log formatting input: info, error (the format has been determined, replace the 'log. error' and other fields with the new todo);
- Error code has been raised for PR, awaiting review @Jimin (internal exceptions are all sea exceptions, packaged uniformly, please follow the specifications in the future)
- Independent log printing (now framework and business logs mixed together) todo
- The regulations are already in place and will be gradually implemented later on
-
Single test coverage target of 70% @WangZhongxiang leads @Jiawei (2/3: no progress in the first two weeks)
- Spring autoconfigure completed (pending merge @Jiawei)
- Inaccurate coverage calculation issue:(https://app.codecov.io/gh/apache/incubator-seata/tree/2.x/integration-tx-api%2Fsrc%2Fmain%2Fjava%2Fio%2Fseata%2Fintegration%2Ftx%2Fapi%2Fjson)
- The goal needs to be achieved
- Change coverage needs to be maintained at 70%
- Sort out the current module coverage document and lead the promotion of @Jiawei @WangZhongxiang 1.8
- What are the standards for writing unit tests, Junit? Mock, version, etc @WangZhongxiang
- What is the ultimate goal of stock governance and what standards must be met for incremental growth?
-
Capacity building for integrated testing and regression @Jiawei @XiongJingliu
- Summer code e2e integration testing framework, Docker composition, to be confirmed (plan stage)
- Confirm the testing plan/standards first @Jiawei will have a brief presentation at the next weekly meeting
- PR address: https://github.com/apache/incubator-seata/pull/6319
- Run integration testing afterwards
- Redis needs to test version compatibility
- There is already a plan, which has been demonstrated after the meeting and is awaiting final confirmation
- Summer code e2e integration testing framework, Docker composition, to be confirmed (plan stage)
-
Compatibility testing (JDK, Arch, Spring core+boot, Druid) @WangLiang
- Test MySQL Driver version; Compatibility testing of different versions of workflow; View together with the testing framework (to be completed by the testing framework)
-
Performance benchmark @Yixia (overall framework has been built) (2/3: no progress yet)
- Only testing framework consumption, SQL logic
- Open source stress testing tools assist in establishing benchmarks
- Including graphical representation (this meaning is yet to be determined)
- Determine the addition of new module implementations;
- Performance benchmark issues;
- POC will demonstrate to everyone @Yixia
- @Yixia Will submit the initial version of the code next week
-
Disposal of backlog PR @ChenJianbin @LiuYuecai
- Go: Some have already contacted the author (recently restarted review, the merger to be merged) @LiuYuecai
- 2/3: Only 1 has not been merged, the others have been merged.
- PR that takes too long, PR that cannot be contacted (important and necessary) will be followed up by us
- Sort out which ones cannot be contacted, and directly handle them on your own. @LiuYuecai before 1.27
- Change the module name of go to Apache xxx @LiuYuecai
- @LiuYuecai feedback: 2/3
- Seata go vulnerability: There are already 0 vulnerabilities here: https://github.com/apache/incubator-seata-go/security
- Seat function alignment: https://github.com/apache/incubator-seata/discussions/6322
- Seata go backlog PR processing: There is still one PR review for 2023 that has not been completed yet: https://github.com/apache/incubator-seata-go/pull/600
- All other PR codes have been reviewed and 2 CI issues are still being addressed
- All other PR codes have been reviewed, and there are 2 CI issues still being addressed, done
- Go: Some have already contacted the author (recently restarted review, the merger to be merged) @LiuYuecai
-
Confirm the use of TCC and whether it is necessary to be compatible with special usage methods @Yixia @Zongjie (follow up with relevant PR)
- For the reminder of how to use TCC annotations, if the second stage annotation is typed on the interface, the default behavior is: supported RPC framework, warning prompt; Unsupported RPC framework, with direct exceptions. The above behavior can be controlled by the same switch to determine whether to display warning log prompts or exception prompts. Todo (PR to be submitted)
-
Seata go direction
- Compliance governance: @Yixia @Jimin @LiuYuecai
- Warehouse, governance of some dependency packages, CVE security vulnerabilities: done
- ModelName to be adjusted
- Construction and Implementation of the Seata Go Saga Framework @Yixia @YinXiangkun @XiongJingliu (Overall Progress: 60-70%)
- Develop and complete preliminary tasks[ https://github.com/apache/incubator-seata/wiki/20231213 ]
- We have initially merged some PRs and there will be a demo in the coming year.
- Align the features and bugfix of Seata Java, currently aligned with version 1.5.1, which needs to be upgraded (modify according to 2. x and not maintain the dual branch strategy) @LiuYuecai has already marked it
- I have made a list: the list is clear, 2 issues have been submitted, and the remaining issues need to be submitted (one of which is being followed up on @TangRulin)
- Compliance governance: @Yixia @Jimin @LiuYuecai
-
Authentication: @JiangJunmin
- Authentication of TM's request and RM's request (PR submitted, pending review) @Jianbin has reviewed the code and it is basically completed. Further confirmation is needed after reviewing it
-
Integrated RocketMQ Task Claim: (Minghua)
- SummerCode2021:
- The project of SummerCode2021 has been submitted by students for basic implementation of PR. PRs have not been merged and need to be integrated into the 2. x branch. It is planned to be released in version 2.1.0. The student responsible for this project is no longer reachable. Now we need a big shot to claim this task and push it forward.
- Topic content: https://github.com/apache/incubator-seata/issues/3752
- PR submitted by project students: https://github.com/apache/incubator-seata/pull/3974
- Takeover of tasks:
- Solution: Provide a separate API
- The new PR has been submitted for review: https://github.com/apache/incubator-seata/pull/6230
- Priority: RocketMQ's SpringBoot Starter, no need to work on it for now. We will only work on the API for now, and version 2.1.0 must be on the API.
- SummerCode2021:
-
Used by reserved plan discussion @ChenJianbin
- Current Used By Data View: https://github.com/apache/incubator-seata/network/dependents
- D: [How to Retain Used By After Migrating to an Apache Organization · Apache/incubator seata · Discussion # 6058 (github. com)]( https://github.com/apache/incubator-seata/discussions/6058 )
- PR: Submitted, awaiting review( https://github.com/apache/incubator-seata/pull/6302 )@Qingming done
-
API compatibility:
- Priority compatibility for major scenarios: Completed, @YinXiangkun done
- Server compatibility:
- Old io. seata class name exists in JSON serialization, completed @ChenJianbin done
- The data in Raft mode is compatible with each other and can only be upgraded to server2.1 or above (note: Raft currently has fewer users, so data compatibility does not need to be considered temporarily) @ChenJianbin
- RM/TM API: Share in groups and divide tasks. (@Jimin trace)
- Interceptor failure issue: Keep the name and package name of the old interceptor@Jimin
- TCC: @Yixia done
- SAGA: @Yin Xiangkun done
- RPC: @Jimin done
- Universal: @WuJiangke done
- The general code has been completed; Currently, there is a need for closing and verification work
-
data compatibility:Mainly for data parsing of some undo_logs, it is necessary to evaluate whether compatibility is necessary; If it takes time, temporarily do not do it@Jimin
-
resource-id
+application-name
unique identifier confirmation @ChenJianbin has a lower priority and currently does not have time (we will initiate further discussions when we have time)-
resource-id
may be duplicated, leading to issues with distribution. Ensure uniqueness, and the final solution is tentative. Please reschedule the meeting for discussion
- Damang Database: Only one schema can be filled in (confirmed with Damang technical personnel)
-
Next meeting communication, prepare documents; Require dynamic scalability;
-
-
Seata go direction:
- Ecological expansion: Bilibili and other service frameworks @Jimin Byte @HaoHongfan. See if we can do it again next week or not by the end of January. (I talked to Byte's Cloud-We-GO and found that the article is hanging on both sides. They will help review it.)
-
Console token automatically refreshes @LiuQiufeng scheme completed done (pending voting, deadline Monday, 20231225) Junmin PR next week
- [Discussion on Token Automatic Renewal Scheme Selection]( https://github.com/apache/incubator-seata/discussions/6180 )
- PR to be submitted (priority authentication processing for TM and RM)
-
TYPE_SEATA_MERGE
messages require an independent thread pool to handle @ChenJianbin Todo- Message independent thread pool for TYPE_SEATA_MERGE · Issue #6197 · apache/incubator-seata (github.com)
- The plan has been determined: divided into two thread pools, one NIO thread pool, and one message processing thread pool.
- PR has not made any progress yet
-
The issue of the startup sequence of RM/proxy init @Haitao will start investing at the end of January
- TM/RM not initialized, rm registered, no longer ignored, direct exception; TODO, confirm
io.seata.core.rpc.netty.RmNettyRemotingClient#registerResource getClientChannelManager().getChannels().isEmpty()
- The plan has been determined, PR is under development, progress: 70% @Haitao
- TM/RM not initialized, rm registered, no longer ignored, direct exception; TODO, confirm
-
Jackson is strongly dependent on scope provided and has been modified to compile dependency @Yixia @Haitao
- Low priority: @Haitao
-
2.1 version core synchronization: (marked with * as important, must be uploaded)
- Multi version protocol PR split, not included in plan 2.1;
- Console configuration (linked to various configuration centers for push pull), @WangLiang 2.1 version not available, separate meeting for discussion; (When the task is sent out, if the PR can be reused, reuse it; if not, restart the PR)
- Saga enhancement; Console Saga designer redesign; Drive front-end resources and keep up with tasks;
- Function enhancement: done
- Insert console: done (implemented by triggering nodejs script through Maven plugin)
- Parallel tasks (PR not merged)
- Saga Trace Spring: PR has been submitted, but due to package name adjustment, it needs to be adjusted again. We will review it later.
- Priority authentication, Junmin. Version 2.1 is required, please let me know if there are any issues
- Token renewal: If version 2.1 cannot catch up, it will not be available
SQL parser: remove- Error code, merge in the first version first;
- Old io. seata APIs are compatible;
- RocketMQ integration
-
Multiple threaded branch registration rollback sequence error or omission
- [Issue # 6311: The issue of concurrent use of seata by multiple threads]( https://github.com/apache/incubator-seata/issues/6311 )
- Resulting in issues with data dependent branches and incorrect rollback order@ChenJianbin (Plan to be discussed: performance and consistency issues, need to be discussed in a meeting again)
- Multiple threads create multiple branches, and when the transaction resolution is rolled back, there are still branches registered, resulting in one less branch being read during the rollback, causing the rollback order to be out of order, and rolling back the transaction.
- The solution can be to merge and roll back, for example, the same resource can be rolled back at once in a single distribution, which can avoid the problem of multiple distributions and possible incorrect rollback order. When distributed locally, it is completely possible to select for update to query the corresponding undo log of xid and roll back according to the local timestamp.
- The disadvantage of undo is that its datatime accuracy needs to be accurate to the nanosecond level
-
Discussion on compatibility issues between high and low versions of Server:
- Raft mode:
- Port synchronization issue (solution: metadata synchronization to solve this problem)
- Protocol solution:
- sofa-bolt: @Yixia synchronize the issue
- grpc:
- python:
- Raft mode:
-
Confusion issue with articles related to Seata on the market: @Jimin
Issue | Description | Github ID | Status |
---|---|---|---|
configuration log output · Issue #6191 · apache/incubator-seata (github.com) | 按照配置所属的模块做日志输出 | 王良 | pr review |
xa 不支持 org.mariadb.jdbc:mariadb-java-client:3.x.x 版本 · Issue #5454 · apache/incubator-seata (github.com) | 支持3.x的mariadb driver | wt-better、@清铭 | todo |
复合主建自增表结构,插入多行数据且未携带主键值时执行异常 · Issue #5043 · apache/incubator-seata (github.com) | 限制sql使用,比如要么都没有pk,要么都有pk,不允许批量插入的时候部分有,部分无的情况 | 建国 | 为BUG,需处理 |
seata1.5.2主键中带有逗号导致获取全局锁lock key值错误 · Issue #5136 · apache/incubator-seata (github.com) | pk存在逗号,导致竞争锁不准的bug 1. 文档标注 2. 客户端校验包含逗号直接报错 3. 协议版本协商功能 4. 含有逗号的base64处理+特殊标识 | 俊敏 | done:1、2,undo: 3、4 |
PR | Description | Reviewer | Status |
---|---|---|---|
feature: saga remove spring by wt-better · Pull Request #6017 · apache/incubator-seata (github.com) | 清铭,健斌,宗杰,王良 | 处理包名再review | |
feature: Saga annotation by leezongjie · Pull Request #5300 · apache/incubator-seata (github.com) | 健斌,亦夏,王良,清铭 | 依赖5399;拉会沟通 @亦夏(处理包名再review) |
- E2E Integration Testing Framework Performance Demonstration (February 3, 2024)
- Container arrangement
- YAmL file defines the testing process, eliminates code intrusion, and forms a workflow
- Can the
workflow
meet the testing framework on Dubbo's end
@Jiangke Wu、@Min Ji、@Jianbin Chen、@Liang Wang、@Te Wang、@Yuecai Liu、@Qiufeng Liu、@Xiangkun Yin、@Jiawei Zhang