Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: avoid dead loop logging during cache plan refresh exceptions #6806

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

wuwen5
Copy link
Contributor

@wuwen5 wuwen5 commented Sep 2, 2024

Avoid dead loop logging during cache plan refresh exceptions

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.37%. Comparing base (cd2e6d2) to head (079f6c0).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...m/datasource/sql/struct/TableMetaCacheFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6806      +/-   ##
============================================
- Coverage     52.38%   52.37%   -0.02%     
  Complexity     6393     6393              
============================================
  Files          1080     1080              
  Lines         37545    37546       +1     
  Branches       4448     4446       -2     
============================================
- Hits          19667    19663       -4     
  Misses        15946    15946              
- Partials       1932     1937       +5     
Files with missing lines Coverage Δ
...m/datasource/sql/struct/TableMetaCacheFactory.java 56.41% <0.00%> (-1.49%) ⬇️

... and 6 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 3, 2024
@funky-eyes funky-eyes changed the title Avoid dead loop logging during cache plan refresh exceptions optimize: avoid dead loop logging during cache plan refresh exceptions Sep 3, 2024
wuwen5 and others added 3 commits September 3, 2024 11:23
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit cec5edf into apache:2.x Sep 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants