-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add TCC three-phase hooks #6766
Merged
funky-eyes
merged 16 commits into
apache:2.x
from
iAmClever:clever_tcc_fence_hook_function
Sep 2, 2024
Merged
feature: add TCC three-phase hooks #6766
funky-eyes
merged 16 commits into
apache:2.x
from
iAmClever:clever_tcc_fence_hook_function
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6766 +/- ##
============================================
+ Coverage 52.16% 52.33% +0.17%
- Complexity 6311 6386 +75
============================================
Files 1067 1079 +12
Lines 37303 37564 +261
Branches 4430 4453 +23
============================================
+ Hits 19458 19658 +200
- Misses 15912 15966 +54
- Partials 1933 1940 +7
|
funky-eyes
reviewed
Aug 21, 2024
integration-tx-api/src/main/java/org/apache/seata/integration/tx/api/fence/FenceHandler.java
Outdated
Show resolved
Hide resolved
081e497
to
135f273
Compare
funky-eyes
reviewed
Aug 25, 2024
integration-tx-api/src/main/java/org/apache/seata/integration/tx/api/fence/hook/TccHook.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Aug 27, 2024
.../src/main/java/org/apache/seata/integration/tx/api/interceptor/ActionInterceptorHandler.java
Outdated
Show resolved
Hide resolved
funky-eyes
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…AmClever/incubator-seata into clever_tcc_fence_hook_function
funky-eyes
reviewed
Aug 30, 2024
...gration-tx-api/src/test/java/org/apache/seata/integration/tx/api/fence/hook/TccHookTest.java
Outdated
Show resolved
Hide resolved
…tx/api/fence/hook/TccHookTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mode: TCC
TCC transaction mode
module/tcc
tcc module
type: feature
Category issues or prs related to feature request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6731
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews