Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add TCC three-phase hooks #6766

Merged
merged 16 commits into from
Sep 2, 2024

Conversation

iAmClever
Copy link
Contributor

@iAmClever iAmClever commented Aug 19, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6731

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 56.62651% with 36 lines in your changes missing coverage. Please review.

Project coverage is 52.33%. Comparing base (b0c2bb2) to head (dfa0d27).
Report is 6 commits behind head on 2.x.

Files with missing lines Patch % Lines
...n/tx/api/interceptor/ActionInterceptorHandler.java 0.00% 16 Missing ⚠️
...va/org/apache/seata/rm/tcc/TCCResourceManager.java 66.66% 12 Missing and 4 partials ⚠️
.../integration/tx/api/fence/hook/TccHookManager.java 78.94% 1 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6766      +/-   ##
============================================
+ Coverage     52.16%   52.33%   +0.17%     
- Complexity     6311     6386      +75     
============================================
  Files          1067     1079      +12     
  Lines         37303    37564     +261     
  Branches       4430     4453      +23     
============================================
+ Hits          19458    19658     +200     
- Misses        15912    15966      +54     
- Partials       1933     1940       +7     
Files with missing lines Coverage Δ
.../integration/tx/api/fence/hook/TccHookManager.java 78.94% <78.94%> (ø)
...n/tx/api/interceptor/ActionInterceptorHandler.java 10.30% <0.00%> (-2.04%) ⬇️
...va/org/apache/seata/rm/tcc/TCCResourceManager.java 58.08% <66.66%> (+8.08%) ⬆️

... and 15 files with indirect coverage changes

@iAmClever iAmClever changed the title add tcc fence hook function feature: add tcc fence hook function Aug 21, 2024
@iAmClever iAmClever force-pushed the clever_tcc_fence_hook_function branch from 081e497 to 135f273 Compare August 23, 2024 07:15
@iAmClever iAmClever changed the title feature: add tcc fence hook function feature: add TCC three-phase hooks Aug 23, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 25, 2024
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. mode: TCC TCC transaction mode module/tcc tcc module labels Aug 25, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 91eb505 into apache:2.x Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: TCC TCC transaction mode module/tcc tcc module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tcc模式是否支持动态数据源,如果不支持能否给个解决思路
2 participants