Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize : remove sdk version checking #6700

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Jul 25, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6699

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added the module/core core module label Jul 25, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Jul 25, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.99%. Comparing base (615d521) to head (eee4a78).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6700      +/-   ##
============================================
+ Coverage     49.96%   49.99%   +0.02%     
+ Complexity     5734     5733       -1     
============================================
  Files          1051     1051              
  Lines         36334    36327       -7     
  Branches       4318     4317       -1     
============================================
+ Hits          18156    18163       +7     
+ Misses        16381    16368      -13     
+ Partials       1797     1796       -1     
Files Coverage Δ
...n/java/org/apache/seata/core/protocol/Version.java 70.73% <ø> (+7.68%) ⬆️
...rg/apache/seata/core/rpc/netty/ChannelManager.java 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

@funky-eyes funky-eyes merged commit b34cfff into apache:2.x Jul 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/core core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SdkVersion checking is not necessary after multi-version protocol support
2 participants