Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: v0 ByteBuf should not decode by super class #6697

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Jul 24, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

#6696

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title fix : v0 ByteBuf should not decode by super class bugfix : v0 ByteBuf should not decode by super class Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.98%. Comparing base (1c0a442) to head (39ddd86).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6697      +/-   ##
============================================
- Coverage     50.81%   49.98%   -0.83%     
+ Complexity     5825     5734      -91     
============================================
  Files          1051     1051              
  Lines         36341    36334       -7     
  Branches       4321     4318       -3     
============================================
- Hits          18467    18163     -304     
- Misses        16014    16375     +361     
+ Partials       1860     1796      -64     
Files Coverage Δ
...n/java/org/apache/seata/core/protocol/Version.java 63.04% <0.00%> (+1.34%) ⬆️
...che/seata/core/rpc/netty/v0/ProtocolDecoderV0.java 0.00% <0.00%> (-4.92%) ⬇️

... and 53 files with indirect coverage changes

@funky-eyes funky-eyes changed the title bugfix : v0 ByteBuf should not decode by super class bugfix: v0 ByteBuf should not decode by super class Jul 24, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Jul 25, 2024
@funky-eyes funky-eyes added the module/core core module label Jul 25, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 615d521 into apache:2.x Jul 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/core core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants