Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: delete static code built on the frontend #6687

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

liuqiufeng
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.89%. Comparing base (1c0a442) to head (4fb717d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6687      +/-   ##
============================================
+ Coverage     50.81%   50.89%   +0.07%     
- Complexity     5825     5835      +10     
============================================
  Files          1051     1051              
  Lines         36341    36341              
  Branches       4321     4319       -2     
============================================
+ Hits          18467    18496      +29     
+ Misses        16014    15986      -28     
+ Partials       1860     1859       -1     

see 7 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the base branch from 2.x to 2.1.0 July 20, 2024 15:59
@slievrly slievrly changed the base branch from 2.1.0 to 2.x July 20, 2024 16:00
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit dda2b2f into apache:2.x Jul 22, 2024
7 checks passed
gongycn added a commit to gongycn/incubator-seata that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants