optimize: add support for configuring exposeProxy in GlobalTransactionScanner #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
first-time contributor
funky-eyes
reviewed
May 21, 2024
...ent/src/main/java/org/apache/seata/spring/boot/autoconfigure/properties/SeataProperties.java
Show resolved
Hide resolved
|
/home/runner/work/incubator-seata/incubator-seata/compatible/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java:[97,46] incompatible types: int cannot be converted to boolean |
Co-authored-by: funkye <[email protected]>
Co-authored-by: funkye <[email protected]>
…u/incubator-seata into feature-expose-proxy-support
Resolved |
funky-eyes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Description of this PR
This PR introduces changes related to the
exposeProxyattribute handling.Ⅱ. Does this pull request fix one issue?
Yes, this pull request addresses the issue reported in 6562
Ⅲ. Why don't you add test cases (unit test/integration test)?
As this PR is primarily about configuring the
exposeProxyattribute, which is more of a configuration change rather than functional changes in the code logic, adding test cases does not apply directly.Ⅳ. Describe how to verify it
To verify the changes introduced by this PR, follow these steps:
exposeProxyattribute.exposeProxyattribute is functioning as expected.Ⅴ. Special notes for reviews
The changes made in this PR primarily focus on adding support for configuring the
exposeProxyattribute. It ensures that theexposeProxysetting is correctly applied in the context of theGlobalTransactionScannerto facilitate the proper functioning of annotations like@GlobalTransactional. TheexposeProxyattribute allows obtaining the proxy object, enabling annotations to function correctly in scenarios where method calls within the same class are involved.