Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(6502): supplement the store unit test cases in the [core] module. #6524

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

llzcx
Copy link

@llzcx llzcx commented May 7, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

  1. supplementary SqlServerLockStoreSql unit testing
  2. supplementary DistributedLockSqlFactory、BaseDistributedLockSqlServer、BaseDistributedLockSql unit testing

Ⅱ. Does this pull request fix one issue?

fixes #6502

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@lightClouds917
Copy link
Contributor

Finished or in progress?
If possible, increase the overall coverage of the core package

@lightClouds917
Copy link
Contributor

add the change log please,You can refer to others

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.51%. Comparing base (7d3cf99) to head (b735252).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6524      +/-   ##
============================================
+ Coverage     50.47%   50.51%   +0.03%     
- Complexity     5831     5841      +10     
============================================
  Files          1051     1051              
  Lines         36340    36340              
  Branches       4319     4319              
============================================
+ Hits          18342    18356      +14     
+ Misses        16183    16167      -16     
- Partials       1815     1817       +2     

see 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: Improve the test case coverage of [core] module to 70%
3 participants