-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: split the task thread pool for committing and rollbacking statuses #6499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Apr 26, 2024
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Apr 26, 2024
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java
Show resolved
Hide resolved
server/src/main/java/org/apache/seata/server/coordinator/DefaultCoordinator.java
Outdated
Show resolved
Hide resolved
funky-eyes
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6499 +/- ##
============================================
- Coverage 50.19% 50.05% -0.15%
+ Complexity 5232 5211 -21
============================================
Files 942 944 +2
Lines 33221 33330 +109
Branches 4022 4029 +7
============================================
+ Hits 16676 16684 +8
- Misses 14938 15038 +100
- Partials 1607 1608 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6478
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews