-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: Splitting dependencies for common, client, and server #6398
Open
wangliang181230
wants to merge
55
commits into
apache:2.x
Choose a base branch
from
wangliang181230:test-dependency-structure
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
optimize: Splitting dependencies for common, client, and server #6398
wangliang181230
wants to merge
55
commits into
apache:2.x
from
wangliang181230:test-dependency-structure
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 36c912f.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6398 +/- ##
============================================
- Coverage 50.81% 50.36% -0.45%
+ Complexity 5285 5243 -42
============================================
Files 942 942
Lines 33270 33275 +5
Branches 4030 4031 +1
============================================
- Hits 16907 16760 -147
- Misses 14698 14893 +195
+ Partials 1665 1622 -43
|
…cture # Conflicts: # compatible/pom.xml
…cture # Conflicts: # changes/en-us/2.x.md # dependencies/pom.xml # pom.xml # test/src/test/java/org/apache/seata/common/ConfigurationTestHelper.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.1) Change log:
server
,console
, andtest-mock-server
优化:拆分通用、客户端、服务端的依赖,并简化server、console、mock-server的依赖配置。
dependencies*
中定义的依赖。spring-boot-dependencies:2.7.18
中的引入的版本号给覆盖了的问题。actions/[email protected]
、actions/[email protected]
, the warnning from actions page:1.2) See the logs of the workflows:
test.yml
,test-druid.yml
https://github.com/wangliang181230/seata/actions?query=branch%3Atest-dependency-structure
1.3) Design:
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews