-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: the problem that the number of mirrors before and after may be inconsistent #6348
Open
funky-eyes
wants to merge
8
commits into
apache:2.x
Choose a base branch
from
funky-eyes:0218
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6348 +/- ##
============================================
+ Coverage 50.38% 52.26% +1.87%
+ Complexity 5250 5215 -35
============================================
Files 942 920 -22
Lines 33289 32008 -1281
Branches 4037 3829 -208
============================================
- Hits 16773 16729 -44
+ Misses 14891 13633 -1258
- Partials 1625 1646 +21
|
funky-eyes
added
type: bug
Category issues or prs related to bug.
module/rm-datasource
rm-datasource module
module/sqlparser
sql-parser module
labels
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module/rm-datasource
rm-datasource module
module/sqlparser
sql-parser module
type: bug
Category issues or prs related to bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.update count大于 before size时,抛出异常阻断
2.当update的where条件中没有主键时,后镜像采用前镜像方式制作,且进行对比前后镜像查询的行数结果
Ⅱ. Does this pull request fix one issue?
fixes #4727
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews