Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:unifty the git information #6271

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Jan 18, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

This PR will unify the git information.Also fixed the problem in #6264 .

docker image inspect docker.io/seataio/seata-server:latest
image

Ⅱ. Does this pull request fix one issue?

fixes #6270

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3351fcf) 51.07% compared to head (e0abcdf) 51.06%.
Report is 2 commits behind head on 2.x.

❗ Current head e0abcdf differs from pull request most recent head 4892ef1. Consider uploading reports for the commit 4892ef1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6271      +/-   ##
============================================
- Coverage     51.07%   51.06%   -0.02%     
+ Complexity     5097     5096       -1     
============================================
  Files           918      918              
  Lines         32031    32031              
  Branches       3865     3865              
============================================
- Hits          16361    16357       -4     
- Misses        14097    14098       +1     
- Partials       1573     1576       +3     

see 5 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it solve the previous issue?

@slievrly
Copy link
Member

#6263

@xingfudeshi
Copy link
Member Author

Can it solve the previous issue?

Yes.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit daf642f into apache:2.x Jan 18, 2024
4 of 6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The git information is inconsistent
3 participants