-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize:unifty the git information #6271
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6271 +/- ##
============================================
- Coverage 51.07% 51.06% -0.02%
+ Complexity 5097 5096 -1
============================================
Files 918 918
Lines 32031 32031
Branches 3865 3865
============================================
- Hits 16361 16357 -4
- Misses 14097 14098 +1
- Partials 1573 1576 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it solve the previous issue?
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
This PR will unify the git information.Also fixed the problem in #6264 .
Ⅱ. Does this pull request fix one issue?
fixes #6270
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews