Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimization fails to build frontend on arm64 #6265

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

liuqiufeng
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3351fcf) 51.07% compared to head (1119aed) 51.04%.
Report is 1 commits behind head on 2.x.

❗ Current head 1119aed differs from pull request most recent head 4ff30b6. Consider uploading reports for the commit 4ff30b6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6265      +/-   ##
============================================
- Coverage     51.07%   51.04%   -0.04%     
+ Complexity     5097     5092       -5     
============================================
  Files           918      918              
  Lines         32031    32031              
  Branches       3865     3865              
============================================
- Hits          16361    16350      -11     
- Misses        14097    14104       +7     
- Partials       1573     1577       +4     

see 7 files with indirect coverage changes

@liuqiufeng liuqiufeng changed the title bugfix: fix arm64 build fail bugfix: fix frontend build failure on arm64 Jan 17, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an optimization PR; only functional bugs are considered bugs.

@liuqiufeng liuqiufeng changed the title bugfix: fix frontend build failure on arm64 optimize: optimization fails to build frontend on arm64 Jan 17, 2024
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit b646e5b into apache:2.x Jan 18, 2024
3 of 5 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Jan 18, 2024
@liuqiufeng liuqiufeng deleted the 2.x_fix_arm64 branch January 24, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants